refactor: split users/models.py into individual files
#421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0bf760a.
braaar
changed the title
users/models.py into individual files
olmari
approved these changes
Feb 9, 2023
|
Thank you @braaar !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I figured I wanted move the model classes in
users/model.pyout to individual files since that will make it easier to modify and maintain the code.In order to do so, I have created an
__init__.pyfile that avoids breaking the old imports from models.py, and I have modified some of the models to use string references in Foreign keys instead of imported model references (avoiding circular dependency).This PR also moves the validlators and the CustomUserManager (which is not a model) out to their own files (from
models.py).