Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX:P:13.0] Fix monitoring of mounted pages #4277

Conversation

dkd-friedrich
Copy link
Member

What this pr does

EXT:solr fails to detect changes on mounted pages correctly in some special occasions:

  • mounted pages not considered during garbage removal / ce updates
  • no_search_sub_entries flag not respected by GarbageRemover
    strategies
  • existing queue items of mounted pages not updated

By adjusting the monitoring related components the issues are fixed,
affected components:

  • GarbageRemover strategies
  • page initializer
  • RecordMonitor
  • DataUpdateHandler

How to test

  • Mount a page located in a sys_folder with enabled option no_search_sub_entries
  • Test updates of page and content elements and check the index queue updates

Fixes: #4275

EXT:solr fails to detect changes on mounted pages correctly in
some special occasions:

* mounted pages not considered during garbage removal / ce updates
* no_search_sub_entries flag not respected by GarbageRemover
  strategies
* existing queue items of mounted pages not updated

By adjusting the monitoring related components the issues are fixed,
affected components:

* GarbageRemover strategies
* page initializer
* RecordMonitor
* DataUpdateHandler

Fixes: TYPO3-Solr#4275
Ports: TYPO3-Solr#4276
Copy link
Collaborator

@dkd-kaehm dkd-kaehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dkd-friedrich dkd-friedrich merged commit ad25480 into TYPO3-Solr:main Jan 24, 2025
9 checks passed
@dkd-friedrich dkd-friedrich deleted the bugfix/main/4275-fix_mountpoint_monitoring branch January 24, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Mount point monitoring incomplete/faulty
2 participants