Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coveralls report #125

Closed
aaschmid opened this issue Dec 28, 2019 · 2 comments
Closed

Fix coveralls report #125

aaschmid opened this issue Dec 28, 2019 · 2 comments
Assignees
@aaschmid
Labels
component: junit-jupiter component: junit-jupiter-params resolution: fixed
Milestone
v2.8

Comments

@aaschmid
Copy link
Member

See Build Scans (https://scans.gradle.com/s/exgu7vzoe5t5c) or local build:

Error while creating report
> Error while analyzing /home/travis/build/TNG/junit-dataprovider/junit-jupiter-params/build/classes/java/main/com/tngtech/junit/dataprovider/DataProvider.class.
  > Can't add different class with same name: com/tngtech/junit/dataprovider/DataProvider

(This is also the problem on master)
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
workaround: remove classes from coveralls analyzation (#125)
0a824ce 
because it fails due to duplicates
@aaschmid
Copy link
Member Author

aaschmid commented Dec 29, 2019 •
edited
Loading

Reason seems to be because FQDN com.tngtech.junit.dataprovider.DataProvider exists twice in junit-jupiter and junit-jupiter-params project.

Possible workarounds:

  1. remove classes from jacocoRootReport -> this may influence coverage analyze
  2. exclude one of the two classes manually ...

Update on workaround 1: Causes coverage analyze to report No class files specified.
Update on workaround 2: works and is maybe good enough ...

@aaschmid aaschmid self-assigned this Dec 29, 2019
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
workaround: remove classes from root coverage generation (#125)
3481294 
because it fails due to duplicate class
`com.tngtech.junit.dataprovider.DataProvider` which appears in
`junit-jupiter` and `junit-jupiter-params`
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
workaround: remove classes from root coverage generation (#125)
4472b9f 
because it fails due to duplicate class
`com.tngtech.junit.dataprovider.DataProvider` which appears in
`junit-jupiter` and `junit-jupiter-params`
@aaschmid aaschmid added this to the next version milestone Dec 29, 2019
@aaschmid
Copy link
Member Author

aaschmid commented Dec 29, 2019 •
edited
Loading

Remaining topic is that since commit 92cef54 no integTest.exec is generated for junit-jupiter and junit-jupiter-params subprojects. Strangely, for junit4 it is generated ...

Update: Rebased on appropriate version before. It is good and working now, see https://coveralls.io/builds/27837805 :-)

aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
workaround: remove classes from root coverage generation (#125)
7235a4a 
because it fails due to duplicate class
`com.tngtech.junit.dataprovider.DataProvider` which appears in
`junit-jupiter` and `junit-jupiter-params`
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
workaround: remove classes from root coverage generation (#125)
1df25c5 
because it fails due to duplicate class
`com.tngtech.junit.dataprovider.DataProvider` which appears in
`junit-jupiter` and `junit-jupiter-params`
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
workaround: exclude classes from root coverage generation (#125)
3497ae1 
because it fails due to duplicate class
`com.tngtech.junit.dataprovider.DataProvider` which appears in
`junit-jupiter` and `junit-jupiter-params`
aaschmid added a commit that referenced this issue Jan 5, 2020
@aaschmid
Merge branch 'fix.coveralls.#125'
0f0b373 
* fix.coveralls.#125:
  add Bnd config in order to fix cached build
  workaround: exclude classes from root coverage generation (#125)
@aaschmid aaschmid closed this as completed Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaschmid aaschmid

Labels
component: junit-jupiter component: junit-jupiter-params resolution: fixed
Projects
None yet
Milestone
v2.8
Development

No branches or pull requests
1 participant
@aaschmid