Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate build scripts to new Kotlin DSL #123

Closed
aaschmid opened this issue Dec 22, 2019 · 1 comment
Closed

Migrate build scripts to new Kotlin DSL #123

aaschmid opened this issue Dec 22, 2019 · 1 comment
Assignees
@aaschmid
Labels
component: core component: junit4 component: junit-jupiter component: junit-jupiter-params resolution: fixed type: refactoring
Milestone
v2.8

Comments

@aaschmid
Copy link
Member

No description provided.

@aaschmid aaschmid self-assigned this Dec 22, 2019
@aaschmid aaschmid added this to the next version milestone Dec 22, 2019
aaschmid added a commit that referenced this issue Dec 23, 2019
@aaschmid
upgrade used plugins as suggested in upgrade guide (#123)
81a3839
aaschmid added a commit that referenced this issue Dec 23, 2019
@aaschmid
migrate settings.gradle to kotlin (#123)
b79ae1c
aaschmid added a commit that referenced this issue Dec 23, 2019
@aaschmid
fix quoting in build.gradle before migrate to kotlin (#123)
6f0582a
aaschmid added a commit that referenced this issue Dec 23, 2019
@aaschmid
add parantheses which can be omitted in Groovy but not Kotlin (#123)
acda135
aaschmid added a commit that referenced this issue Dec 23, 2019
@aaschmid
prepare stepwise migration by splitting build logic (#123)
ded3f1e 
* only required stuff goes to new build file (Kotlin DSL)
* everything else is kept in legacy but renamed build file (Groovy DSL)

Note:
* `withType` does no longer work with full qualified import (no idea why) so comment it and mark it with TODO
aaschmid added a commit that referenced this issue Dec 23, 2019
@aaschmid
migrate extra properties, buildScan and allprojects configuration to …
231bcb0 
…Kotlin DSL (#123)
aaschmid added a commit that referenced this issue Dec 23, 2019
@aaschmid
migrate first generic subprojects configuration to Kotlin DSL (#123)
3b3665b 
Note: Using a `String` for dependency configuration is ugly but the
alternative is to apply `java-library` plugins within `plugins` closure
which would also apply it to root project which is very much unwanted.
This also does not allow to use `java` closure and `javadoc` task.

Alternative: We could split build into multiple files with a lot
duplicated code, though.

Which one is better?
aaschmid added a commit that referenced this issue Dec 23, 2019
@aaschmid
migrate core subproject configuration to Kotlin DSL (#123)
c0e5216
aaschmid added a commit that referenced this issue Dec 23, 2019
@aaschmid
migrate junit4 subproject configuration to Kotlin DSL (#123)
2b1be7c
aaschmid added a commit that referenced this issue Dec 23, 2019
@aaschmid
migrate junit-jupiter* subproject configuration to Kotlin DSL (#123)
c1f2bb6
aaschmid added a commit that referenced this issue Dec 23, 2019
@aaschmid
migrate junit-jupiter and junit-jupiter-params subprojects configura…
19b24cc 
…tion to Kotlin DSL (#123)
aaschmid added a commit that referenced this issue Dec 23, 2019
@aaschmid
migrate second generic subprojects configuration to Kotlin DSL (#123)
3bcbc2f
aaschmid added a commit that referenced this issue Dec 23, 2019
@aaschmid
migrate coveralls and its required jacoco config (#123)
b36b61e
aaschmid added a commit that referenced this issue Dec 24, 2019
@aaschmid
migrate settings.gradle to kotlin (#123)
f66fb2d
aaschmid added a commit that referenced this issue Dec 24, 2019
@aaschmid
fix quoting in build.gradle before migrate to kotlin (#123)
3e56ee0
aaschmid added a commit that referenced this issue Dec 24, 2019
@aaschmid
add parantheses which can be omitted in Groovy but not Kotlin (#123)
464b359
aaschmid added a commit that referenced this issue Dec 24, 2019
@aaschmid
prepare stepwise migration by splitting build logic (#123)
48b5561 
* only required stuff goes to new build file (Kotlin DSL)
* everything else is kept in legacy but renamed build file (Groovy DSL)

Note:
* `withType` does no longer work with full qualified import (no idea why) so comment it and mark it with TODO
aaschmid added a commit that referenced this issue Dec 24, 2019
@aaschmid
migrate extra properties, buildScan and allprojects configuration to …
709351a 
…Kotlin DSL (#123)
aaschmid added a commit that referenced this issue Dec 24, 2019
@aaschmid
migrate first generic subprojects configuration to Kotlin DSL (#123)
83ab30d 
Note: Using a `String` for dependency configuration is ugly but the
alternative is to apply `java-library` plugins within `plugins` closure
which would also apply it to root project which is very much unwanted.
This also does not allow to use `java` closure and `javadoc` task.

Alternative: We could split build into multiple files with a lot
duplicated code, though.

Which one is better?
aaschmid added a commit that referenced this issue Dec 24, 2019
@aaschmid
migrate core subproject configuration to Kotlin DSL (#123)
a2cbc83
aaschmid added a commit that referenced this issue Dec 24, 2019
@aaschmid
migrate junit4 subproject configuration to Kotlin DSL (#123)
b699055
aaschmid added a commit that referenced this issue Dec 24, 2019
@aaschmid
migrate junit-jupiter* subproject configuration to Kotlin DSL (#123)
995a467
aaschmid added a commit that referenced this issue Dec 24, 2019
@aaschmid
migrate junit-jupiter and junit-jupiter-params subprojects configura…
24cf0c1 
…tion to Kotlin DSL (#123)
aaschmid added a commit that referenced this issue Dec 24, 2019
@aaschmid
migrate second generic subprojects configuration to Kotlin DSL (#123)
bc74a36
aaschmid added a commit that referenced this issue Dec 24, 2019
@aaschmid
remove no longer used TouchTestResults class in legacy build file (#123)
8bee910
aaschmid added a commit that referenced this issue Dec 24, 2019
@aaschmid
migrate coveralls and its required jacoco config (#123)
126bd67
aaschmid added a commit that referenced this issue Dec 24, 2019
@aaschmid
migrate cpd config (#123)
270e3f0
aaschmid added a commit that referenced this issue Dec 24, 2019
@aaschmid
migrate remaining publishing configuration to Kotlin DSL (#123)
01b3914
aaschmid added a commit that referenced this issue Dec 27, 2019
@aaschmid
migrate remaining publishing configuration to Kotlin DSL (#123)
9a8fe62
@aaschmid aaschmid changed the title Mgrate build scripts to new Kotlin DSL Migrate build scripts to new Kotlin DSL Dec 28, 2019
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
upgrade used plugins as suggested in upgrade guide (#123)
2cee063
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
migrate settings.gradle to kotlin (#123)
4e3b4ef
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
fix quoting in build.gradle before migrate to kotlin (#123)
039355b
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
add parantheses which can be omitted in Groovy but not Kotlin (#123)
4d04586
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
prepare stepwise migration by splitting build logic (#123)
5950fa5 
* only required stuff goes to new build file (Kotlin DSL)
* everything else is kept in legacy but renamed build file (Groovy DSL)

Note:
* `withType` does no longer work with full qualified import (no idea why) so comment it and mark it with TODO
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
migrate extra properties, buildScan and allprojects configuration to …
5c104a8 
…Kotlin DSL (#123)
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
migrate first generic subprojects configuration to Kotlin DSL (#123)
8de72c3 
Note: Using a `String` for dependency configuration is ugly but the
alternative is to apply `java-library` plugins within `plugins` closure
which would also apply it to root project which is very much unwanted.
This also does not allow to use `java` closure and `javadoc` task.

Alternative: We could split build into multiple files with a lot
duplicated code, though.

Which one is better?
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
migrate core subproject configuration to Kotlin DSL (#123)
bc2f176
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
migrate junit4 subproject configuration to Kotlin DSL (#123)
5868101
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
migrate junit-jupiter* subproject configuration to Kotlin DSL (#123)
c851502
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
migrate junit-jupiter and junit-jupiter-params subprojects configura…
db047f0 
…tion to Kotlin DSL (#123)
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
migrate second generic subprojects configuration to Kotlin DSL (#123)
a67b9dc
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
remove no longer used TouchTestResults class in legacy build file (#123)
ee51892
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
migrate coveralls and its required jacoco config (#123)
30cf116
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
migrate cpd config (#123)
bfed3ef
aaschmid added a commit that referenced this issue Dec 29, 2019
@aaschmid
migrate remaining publishing configuration to Kotlin DSL (#123)
7768159
@aaschmid
Copy link
Member Author

Tested and rebased quite a lot but now having a pretty much stable and consistent version :-)

aaschmid added a commit that referenced this issue Jan 5, 2020
@aaschmid
Merge branch 'migrate.to.kotlin.#123'
c91a529 
* migrate.to.kotlin.#123: (25 commits)
  fix file includes for resulting JARs
  centralize and upgrade dependencies
  get rid of not required LifecyclePlugin wrapper
  use Kotlins "it" for simple closures
  prefer methods which favor configuration avoidance
  introduce caching for travis CI builds
  use Bnd Gradle Plugins via plugins {} API
  migrate remaining publishing configuration to Kotlin DSL (#123)
  migrate cpd config (#123)
  migrate coveralls and its required jacoco config (#123)
  remove no longer used TouchTestResults class in legacy build file (#123)
  migrate second generic subprojects configuration to Kotlin DSL (#123)
  migrate junit-jupiter and junit-jupiter-params subprojects configuration to Kotlin DSL (#123)
  migrate junit-jupiter* subproject configuration to Kotlin DSL (#123)
  migrate junit4 subproject configuration to Kotlin DSL (#123)
  migrate core subproject configuration to Kotlin DSL (#123)
  migrate first generic subprojects configuration to Kotlin DSL (#123)
  migrate extra properties, buildScan and allprojects configuration to Kotlin DSL (#123)
  prepare stepwise migration by splitting build logic (#123)
  add parantheses which can be omitted in Groovy but not Kotlin (#123)
  ...
@aaschmid aaschmid closed this as completed Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaschmid aaschmid

Labels
component: core component: junit4 component: junit-jupiter component: junit-jupiter-params resolution: fixed type: refactoring
Projects
None yet
Milestone
v2.8
Development

No branches or pull requests
1 participant
@aaschmid