Lazuli v3 Update #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New pypi folder used for distribution to avoid polluting the requirements with twine-related dependencies
Distribution-related and documentation-related dependencies are no longer part of the requirements
Contains documentation- and distribution-related dependencies
Also similar changes to account module, where previously missed. Some non-breaking sanity checks were also added to the character module.
Signed-off-by: KOOKIIEStudios <25145447+KOOKIIEStudios@users.noreply.github.com>
This is to ensure compliance with PEP 621, where pyproject.toml is the new preferred way of handling metadata.
setup.py should not be needed as Lazuli v3 is expected to target Python 3.10 and higher; there are no legacy support concerns.
Signed-off-by: KOOKIIEStudios <25145447+KOOKIIEStudios@users.noreply.github.com>
Obtained from: /~https://github.com/TEAM-SPIRIT-Productions/MapleStoryJobIDs/blob/main/jobid_to_name.yaml - there isn't really a huge need for a CI/CD approach to this right now
New dependency: ruamel.yaml is a YAML 1.2 loader/dumper package for Python, that supports comments.
Signed-off-by: KOOKIIEStudios <25145447+KOOKIIEStudios@users.noreply.github.com>
Use PyPA Build instead of setuptools, per the new packaging recommendations on Python's official documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
PortraytopdocJOBSdictionary in__init__module with the SpiritSuite YAML documentpyproject.toml,setuptools, andbuildfor distributionFor detailed explanation see: /~https://github.com/TEAM-SPIRIT-Productions/Lazuli/wiki/Migration-from-v2-to-v3
All unit tests passed
Unit tests after installing from TestPyPI:
