[UI] Remove default override of _payment to allow using ui event #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oallain
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
@GSadee After merged Sylius/PayPalPlugin#276 we can now merge this one.
NoResponseMate
approved these changes
Feb 6, 2024
GSadee
force-pushed
the
fix/remove-payment-override
branch
from
e0553ba to
185eb48
Compare
GSadee
approved these changes
Apr 15, 2024
|
Thank you, Jibé! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follow up Sylius/Sylius#13817 and Sylius/PayPalPlugin#276
I noticed that when installing refund plugin on a 1.12 version, I have both Refund functionnality from plugin and the native button under payment.
The refund plugin disable the native button using sylius event, but with this template coming in standard, that has no effect.
Let's remove it, and fully embrace the sylius ui event system 🤗
The paypal customization has been backported in paypal plugin ui events.