-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace jshint for eslint #705
Conversation
Forgot to mention that it includes /~https://github.com/Gillespie59/eslint-plugin-angular from @Gillespie59 |
As discussed on Twitter, you change some code ($digest vs $apply), I think after the integration of my plugin. I do not know if it has an impact on your archetype, but if you want I can update my rule, because it check the wrong thing. https://egghead.io/lessons/angularjs-apply-vs-digest Except from that, everything looks good ;) |
I have publish a 0.4.0 with a fix for this issue. You can update your package.json with this version. |
Thanks for your analysis. Will take the new version :) |
Looking forward to this one. |
👍 but need rebase with master |
Conflicts: test/npm-shrinkwrap.json
Conflicts: app/templates/_package.json app/templates/gulp/_scripts.js test/npm-shrinkwrap.json
Finally #168