Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace jshint for eslint #705

Merged
merged 5 commits into from
Aug 25, 2015
Merged

Replace jshint for eslint #705

merged 5 commits into from
Aug 25, 2015

Conversation

Swiip
Copy link
Owner

@Swiip Swiip commented Aug 4, 2015

Finally #168

@Swiip
Copy link
Owner Author

Swiip commented Aug 6, 2015

Forgot to mention that it includes /~https://github.com/Gillespie59/eslint-plugin-angular from @Gillespie59

@EmmanuelDemey
Copy link

As discussed on Twitter, you change some code ($digest vs $apply), I think after the integration of my plugin.
But according to this video the $digest method only update the current scope and its children. The $apply method will start the refresh from the $rootScope. So maybe the $digest is more performant than the second one.

I do not know if it has an impact on your archetype, but if you want I can update my rule, because it check the wrong thing.

https://egghead.io/lessons/angularjs-apply-vs-digest

Except from that, everything looks good ;)

@EmmanuelDemey
Copy link

I have publish a 0.4.0 with a fix for this issue. You can update your package.json with this version.

@Swiip
Copy link
Owner Author

Swiip commented Aug 9, 2015

Thanks for your analysis. Will take the new version :)

@sdornan
Copy link

sdornan commented Aug 12, 2015

Looking forward to this one.

@zckrs
Copy link
Collaborator

zckrs commented Aug 24, 2015

👍 but need rebase with master

Swiip added 3 commits August 24, 2015 20:44
Conflicts:
	app/templates/_package.json
	app/templates/gulp/_scripts.js
	test/npm-shrinkwrap.json
zckrs pushed a commit that referenced this pull request Aug 25, 2015
Replace JSHint for ESLint
@zckrs zckrs merged commit c0b7424 into master Aug 25, 2015
@Swiip Swiip deleted the eslint branch September 9, 2015 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants