Add Angular New Router #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Done. I also added 2 npm commands I often use while developping and was tired of retyping them every time. |
|
+1 for this. Any idea when it will be merged in? |
|
I was waiting for @zckrs to come back from holliday for a review. Nothing stop this apart from that I think. |
|
I cloned the repo and merged the branch in locally. I can confirm that it's working nicely for me. 👍 |
|
Shouldn't the router as it exists in the Angular 2 repo be used instead? From angular/router readme: I think this is it? /~https://github.com/angular/angular/tree/master/modules/angular1_router |
|
👍 |
zckrs
force-pushed
the
angular-new-router
branch
from
6f15975 to
7d7f409
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/~https://github.com/angular/router
The lib is still experimental but it allows to try it easily. Seems to work pretty well. TSLint cry because there is no typings but for the rest it's ok.
As usual, I push early code to get remarks and do the tests after.