add 5m timeout to captive portal #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would prefer an implementation as we have with the Panel FW where we are rebooting until WiFi is available. This is the only way to get out of the mentioned scenario to recover the Wifi connection after power drop. |
|
I have updated this in line with your comments @moinmoin-sh - can you review and approve if you are happy with it now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a device which is rebooting when there is no WiFi available, from sitting in captive portal mode indefinitely.
The Rack32 needs to continue booting and allow processing of events in failover mode if the network or MQTT is down.
Ideally we would periodically try to reconnect to WiFi once the captive portal expires, if there are WiFi creds saved, but I am not sure how easy this is to do with the WifiManager lib.