Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show preview of what the theme will look like #104

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Conversation

BryceStevenWilley
Copy link
Contributor

Mostly pure HTML from https://bootswatch.com/default/ in test_html.html, and using a trick from https://stackoverflow.com/a/13883978/11416267 to add the generated theme to the CSS of the page using Javascript. Works great, might want to consider culling down some of the things shown to be just the docassemble components, since there's a whole lot, and most of it, people won't have to worry about.

The only thing is that there's some extra margin on each component in bootswatch that we don't have. Can add it if we think things aren't readable, but it didn't make too much of a different to me so I avoided adding too much custom css for just this page.

Fixes #11.

Screenshot from 2023-10-10 21-03-54

Mostly pure HTML from https://bootswatch.com/default/, and using a trick from
https://stackoverflow.com/a/13883978/11416267 to add the generated theme to
the CSS of the page using Javascript. Works great, might want to consider
culling down some of the things shown to be just the docassemble components,
since there's a whole lot, and most of it, people won't have to worry about.
Copy link
Member

@nonprofittechy nonprofittechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for this

Copy link
Contributor

@plocket plocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, great methodology!

One nit I'm wondering about is why the "Back to Dashboard" looks so small. Maybe that was already that way, though or maybe it's just in contrast to the buttons above it.

The other nit is that the files provided at the top kind of get drowned out by the preview underneath. We don't have to worry about that, though, unless people start coming to us with confusion.

@BryceStevenWilley
Copy link
Contributor Author

One nit I'm wondering about is why the "Back to Dashboard" looks so small. Maybe that was already that way, though or maybe it's just in contrast to the buttons above it.

It's always been that small, it's the small bootstrap button. Definitely would look smaller compared to the normal sizes. I don't want to change it for just that screen though, and I think small is the right size for a nav button like that, also considering "Dashboard" still shows up in the dropdown where it normally is.

The other nit is that the files provided at the top kind of get drowned out by the preview underneath.

That's a fair point. I went ahead and bolded them, and put one of those horizontal lines between the files at the top and the examples below. Hopefully that makes it a bit clearer. Like you said, we can re-evaluate if any one gets confused.

Screenshot from 2023-10-11 11-15-14

@BryceStevenWilley BryceStevenWilley merged commit 5bcd396 into main Oct 11, 2023
@BryceStevenWilley BryceStevenWilley deleted the full_preview branch October 11, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a theme tester interview?
3 participants