Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Bootstrap theme default #103

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Better Bootstrap theme default #103

merged 3 commits into from
Oct 11, 2023

Conversation

BryceStevenWilley
Copy link
Contributor

Correcting a mistake I made a while back; the default colors are horrible. I probably made them for testing and never changed them back. It is a problem because it's impossible to tell what the colors will be before generating the theme, and it's not clear what those values are by default in docassemble.

Now, the default colors when you are typing the theme are the same ones from docassemble's base theme. So you'll get what you expect.

Also shortened a the bootstrap interview label from the menu, which was too long.

Correcting a mistake I made a while back; the default colors are horrible.
That's not a huge issue, but it is a problem because it's impossible to tell
before generating the theme, and it's not clear what those values are by
default in docassemble.

Now, the default colors when you are typing the theme are the same ones from
docassemble's base theme. So you'll get what you expect.
@BryceStevenWilley BryceStevenWilley changed the title Better default Better Bootstrap theme default Oct 11, 2023
Copy link
Member

@nonprofittechy nonprofittechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Co-authored-by: Quinten Steenhuis <qsteenhuis@suffolk.edu>
@BryceStevenWilley BryceStevenWilley merged commit 2dce9a3 into main Oct 11, 2023
@BryceStevenWilley BryceStevenWilley deleted the better_default branch October 11, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants