Refactor/service manager #2401
Merged
Refactor/service manager #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refactor/service-manager
dr-bonez
reviewed
Aug 21, 2023
backend/src/manager/mod.rs
Outdated
| TransitionState::BackingUp( | ||
| tokio::spawn( | ||
| self.perform_backup(backup_guard) | ||
| .then(finnish_up_backup_task(self.transition.clone(), send)), |
dr-bonez
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
The idea about this is that the service manager should be a state machine, so we shall make the code actually a state machine. The code ends up being simpler, the thing then acts like a actor, and the state can be observed.
Proof
Here we show that we can stop and start services.
And the restart works
and backup/ restore
Then deleted then restored 2/3
Proof that the config is working
ProofOfWorkingConfig.mp4