Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Exposing the rsync that we have to the js #1907

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Conversation

Blu-J
Copy link
Contributor

@Blu-J Blu-J commented Nov 4, 2022

Proof it works

Via the test that is added to the js_scripts.rs

@Blu-J Blu-J requested a review from dr-bonez November 4, 2022 19:16
@Blu-J Blu-J force-pushed the feat/add-rsync-to-js branch from a164d6f to b0f67c4 Compare November 4, 2022 19:29
@Blu-J Blu-J marked this pull request as draft November 4, 2022 23:00
@Blu-J Blu-J marked this pull request as ready for review November 7, 2022 18:10
@Blu-J Blu-J force-pushed the feat/add-rsync-to-js branch 5 times, most recently from da4c9a1 to d846f01 Compare November 7, 2022 20:53
@Blu-J Blu-J marked this pull request as draft November 7, 2022 23:56
@Blu-J Blu-J force-pushed the feat/add-rsync-to-js branch from d846f01 to d700fd7 Compare November 8, 2022 16:35
@Blu-J Blu-J marked this pull request as ready for review November 8, 2022 17:54
@Blu-J Blu-J force-pushed the feat/add-rsync-to-js branch from d700fd7 to bd3e2f1 Compare November 8, 2022 19:09
@Blu-J
Copy link
Contributor Author

Blu-J commented Nov 8, 2022

closes: #1713

chore: Make the commit do by checksum.

chore: Remove the logging at the start

chore: use the defaults of the original.

chore: Convert the error into just the source.

chore: Remove some of the unwraps
@Blu-J Blu-J force-pushed the feat/add-rsync-to-js branch from bd3e2f1 to 718c8aa Compare November 9, 2022 16:55
@dr-bonez dr-bonez merged commit 5ecc6d0 into next Nov 9, 2022
dr-bonez pushed a commit that referenced this pull request Nov 29, 2022
chore: Make the commit do by checksum.

chore: Remove the logging at the start

chore: use the defaults of the original.

chore: Convert the error into just the source.

chore: Remove some of the unwraps
@MattDHill MattDHill deleted the feat/add-rsync-to-js branch December 12, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants