Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(actors): Default token settings #1655

Merged
merged 2 commits into from
Aug 10, 2024

Conversation

obrenckle
Copy link
Contributor

@obrenckle obrenckle commented Aug 9, 2024

Basic implementation of default actor token settings suggested in #1652
It's mostly a proof of concept while someone review the suggested defaults and decide where best to put that code.

@obrenckle obrenckle force-pushed the actor_token_defaults branch 4 times, most recently from cb93072 to e4b525c Compare August 9, 2024 16:10
@wrycu
Copy link
Collaborator

wrycu commented Aug 9, 2024

This looks good. My only thoughts are that non-PC actors should default to hostile, not neutral... and we don't need numbers appended to minion groups.

If you're comfortable making those changes, I'd be happy to accept the PR. If not, I can base a new PR from this draft and make it myself.

Regardless, I appreciate the help and time you're putting in!

@obrenckle
Copy link
Contributor Author

That's easy enough, I'll update the PR and remove the Draft status.
Do I leave the prepended adjectives for Rivals ?

@wrycu
Copy link
Collaborator

wrycu commented Aug 9, 2024

I'd rather we put it behind a setting, in case someone doesn't like it. But I changed the settings format after you started (#1657), so I can make the change after the PR is merged... or you can merge main into your working code and add it to the actorSettings setting menu.

@obrenckle
Copy link
Contributor Author

I'll give it a try, I'll have something ready tomorrow.

@obrenckle obrenckle force-pushed the actor_token_defaults branch 3 times, most recently from 03adaac to b8808ba Compare August 10, 2024 09:46
@obrenckle obrenckle marked this pull request as ready for review August 10, 2024 09:49
@obrenckle obrenckle force-pushed the actor_token_defaults branch 2 times, most recently from 1ebc967 to 2f2e3d1 Compare August 10, 2024 10:16
@obrenckle obrenckle force-pushed the actor_token_defaults branch from 2f2e3d1 to e84fdaf Compare August 10, 2024 10:16
@obrenckle
Copy link
Contributor Author

Should be good, though I couldn't find how settings where ordered in their respective menus.

@wrycu
Copy link
Collaborator

wrycu commented Aug 10, 2024

@obrenckle looks good. Can you please create a new setting without removing token_configured? This is used to configure the prototype token (but still allow the user to override it if they prefer.)

Should be good, though I couldn't find how settings where ordered in their respective menus.

Same :p

@wrycu
Copy link
Collaborator

wrycu commented Aug 10, 2024

Actually, I'll just do it. :)

@wrycu wrycu merged commit 7518fe5 into StarWarsFoundryVTT:main Aug 10, 2024
@obrenckle
Copy link
Contributor Author

Sorry, I thought you had set the token_configure as an example, I should have checked with grep...

@obrenckle obrenckle deleted the actor_token_defaults branch August 11, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants