-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(actors): Default token settings #1655
feat(actors): Default token settings #1655
Conversation
cb93072
to
e4b525c
Compare
This looks good. My only thoughts are that non-PC actors should default to hostile, not neutral... and we don't need numbers appended to minion groups. If you're comfortable making those changes, I'd be happy to accept the PR. If not, I can base a new PR from this draft and make it myself. Regardless, I appreciate the help and time you're putting in! |
That's easy enough, I'll update the PR and remove the Draft status. |
I'd rather we put it behind a setting, in case someone doesn't like it. But I changed the settings format after you started (#1657), so I can make the change after the PR is merged... or you can merge main into your working code and add it to the |
I'll give it a try, I'll have something ready tomorrow. |
03adaac
to
b8808ba
Compare
1ebc967
to
2f2e3d1
Compare
2f2e3d1
to
e84fdaf
Compare
Should be good, though I couldn't find how settings where ordered in their respective menus. |
@obrenckle looks good. Can you please create a new setting without removing
Same :p |
Actually, I'll just do it. :) |
Sorry, I thought you had set the |
Basic implementation of default actor token settings suggested in #1652
It's mostly a proof of concept while someone review the suggested defaults and decide where best to put that code.