Mandar css 1386 #1407
Merged
Mandar css 1386 #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Esrin
approved these changes
Apr 6, 2024
Comment on lines
+635
to
+671
| /* confirmed good */ | ||
| .starwarsffg.sheet .sheet-body.gear { | ||
| height: calc(100% - 24rem); | ||
| } | ||
|
|
||
| .starwarsffg.sheet .sheet-body.weapon, .starwarsffg.sheet .sheet-body.armour { | ||
| height: calc(100% - 32rem); | ||
| } | ||
|
|
||
| .starwarsffg.sheet .sheet-body.shipweapon { | ||
| height: calc(100% - 40rem); | ||
| } | ||
|
|
||
| .starwarsffg.sheet .sheet-body.itemattachment { | ||
| height: calc(100% - 18rem); | ||
| } | ||
|
|
||
| .starwarsffg.sheet .sheet-body.ability { | ||
| height: calc(100% - 1.5rem); | ||
| } | ||
|
|
||
| .starwarsffg.sheet .sheet-body.shipattachment { | ||
| height: calc(100% - 22.75rem); | ||
| } | ||
|
|
||
| .starwarsffg.sheet .sheet-body.homesteadupgrade { | ||
| height: calc(100% - 20rem); | ||
| } | ||
|
|
||
| .starwarsffg.sheet .sheet-body.talent { | ||
| height: calc(100% - 26rem); | ||
| } | ||
|
|
||
| .starwarsffg.sheet .sheet-body.species { | ||
| height: calc(100% - 24rem); | ||
| } | ||
|
|
There was a problem hiding this comment.
Gonna approve this PR cause I don't wanna slow you down, but bear in mind this could easily become nightmareish to maintain 😂
There was a problem hiding this comment.
Agreed. Perhaps we can chat on a non-stupid way of doing it. This is what I found works, but it doesn't appear like the correct solution, even to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.