Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token visibility 1343 #1367

Merged
merged 6 commits into from
Feb 22, 2024
Merged

Token visibility 1343 #1367

merged 6 commits into from
Feb 22, 2024

Conversation

wrycu
Copy link
Collaborator

@wrycu wrycu commented Feb 22, 2024

Handle hidden actors. Hidden actors have their initiative slots shown but names and images hidden from players.

GM view:

image

Player view of the same combat at the same time:

image

* WIP handling of token visibility in combat tracker

#1343
* improve token visibility syncing
* now properly hides/shows claimed slots based on if the token is visible

#1343
* handle CSS issues with the "active" class not being properly set
* handle confusion around which actor is active
* localize strings for hidden slots
* remove slot names for hidden slots (only applies for non-GMs)
* correct image "has gone" state not being reset at the start of a new round
* handle removing combatants confusing the claimed slot state

#1343
#1340
* redo the handling of visibility to simplify and correct remaining (known) bug

#1343
@wrycu wrycu requested a review from Esrin February 22, 2024 02:07
* remove console logs

#1343
Copy link
Collaborator

@Esrin Esrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a GM I'd personally prefer to keep hidden actor slots completely hidden from the players until I'm ready to reveal them, but I'm happy to bow to the majority here as I can work around it by just not adding them to combat until they are revealed. The downside of that is I then have to roll their initiatives which is a bit less slick than having them already secretly prepared. 🤷

@Esrin Esrin merged commit d4d1373 into main Feb 22, 2024
@Esrin Esrin deleted the token_visibility_1343 branch February 22, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants