Token hud 1334 #1364
Merged
Token hud 1334 #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* now shows the alive/total minion group size on tokens #1334
* now shows ranks in adversary #1334
* now shows a different symbol for minion groups which exceed a certain threshold #1334
# Conflicts: # lang/en.json # modules/swffg-main.js
* adds custom images for adversary levels based on community feedback #1334
* add outline and scale images down instead of raw resize #1334
Esrin
approved these changes
Feb 19, 2024
Comment on lines
+35
to
+38
| const borderWidth = 0.35; | ||
| const friendlyColor = "0x00A2E84D"; | ||
| const enemyColor = "0x8800154D"; | ||
| const overflowColor = "0xDAA520"; |
There was a problem hiding this comment.
For accessibility / customisability these sorts of things would probably be better as CSS variables, or system settings, so that other modules can interact with them, and users can easily tweak them. But that's a long term concern, not a "get it working" concern.
Comment on lines
+895
to
+898
| if (token?.actor?.type === "minion") { | ||
| drawMinionCount(token); | ||
| } | ||
| if (["character"].includes(token?.actor?.type)) { |
There was a problem hiding this comment.
haha, FWIW that is because I expect the one on line 898 to be expanded in the future, whereas 895 is static. fair point, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.