Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): update quality links #1347

Merged
merged 1 commit into from
Feb 11, 2024
Merged

feat(chat): update quality links #1347

merged 1 commit into from
Feb 11, 2024

Conversation

wrycu
Copy link
Collaborator

@wrycu wrycu commented Feb 6, 2024

  • now embeds item quality data in chat messages instead of linking to it
  • this means that previous messages will always properly link to the item at tht time of sending messages, even if items are deleted or users don't have permission to view them
  • existing messages will use existing logic

#1336

* now embeds item quality data in chat messages instead of linking to it
* this means that previous messages will always properly link to the item at tht time of sending messages, even if items are deleted or users don't have permission to view them
* existing messages will use existing logic

#1336
@wrycu wrycu requested a review from Esrin February 6, 2024 22:20
modules/swffg-main.js Show resolved Hide resolved
modules/swffg-main.js Show resolved Hide resolved
@Esrin Esrin merged commit a71ef4d into main Feb 11, 2024
@Esrin Esrin deleted the item_quality_data_1336 branch February 11, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants