Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with Minion talentList #1151

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

tucker87
Copy link
Contributor

Fix for #1148

@Rysarian
Copy link
Collaborator

The way deleting talents work is by using the info icon and then it opens up the list of talents which can be marked for deletion. I think you might just be able to add copy the info line over to the second part.

@tucker87
Copy link
Contributor Author

Ah, I wasn't aware of this... I tested this change and the issues with this.actor.talentList crop back up and prevent the dialog from popping up for minions. I'll look at fixing that as it's issues are spreading.

@tucker87 tucker87 changed the title Add delete button to talents partial Fixed issue with Minion talentList Jan 10, 2023
@tucker87
Copy link
Contributor Author

Found the issue!

_prepareMinionData(actorData) { const data = actorData.system;

_prepareCharacterData(actorData) { const data = actorData;

Then they both ran: data.talentList = globalTalentList; but that did different things.

@Rysarian
Copy link
Collaborator

No worries. Thanks for getting all of these PRs in to help out with the system!

Copy link
Collaborator

@Esrin Esrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵️

@Esrin Esrin merged commit 520d261 into StarWarsFoundryVTT:foundry-10 Jan 11, 2023
@tucker87 tucker87 deleted the addDeleteToTalents branch January 12, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants