Added support for 'aapdd' style shorthand dice rolling. #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tucker87
force-pushed
the
diceShorthand
branch
from
a906e03 to
475d7ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested using a Discord bot for a bit and enjoyed the shorthand it used for dice so I've made the /roll command able to use that shorthand.
aapddis equivalent to2da+1dp+2di(I've put a substitute to allow fordorito mean difficultyThis doesn't kick in unless the main parser comes back with a
StringTermwithout a number in it which will fail to evaluate so it shouldn't clash with any existing systems.