Fix deprecated accessors in swffg-main.js migration code #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus one null-safe fix in item-ffg.js
|
@wrycu just to make you a bit more nervous about world migration 😂 |
Esrin
commented
Sep 10, 2022
modules/items/item-ffg.js
Outdated
| @@ -119,7 +119,7 @@ export class ItemFFG extends ItemBaseFFG { | |||
|
|
|||
| if (data?.itemattachment) { | |||
| data.itemattachment.forEach((attachment) => { | |||
| const activeModifiers = attachment.system.itemmodifier.filter((i) => i.system?.active); | |||
| const activeModifiers = attachment.system.itemmodifier?.filter((i) => i.system?.active); | |||
There was a problem hiding this comment.
Actually this error I was seeing is the result of a migration problem we'll need to tackle.
The attachment object we're looping through here isn't a real instance of an ItemData document, it's an array of our hacky deep embedded items... as such it doesn't have a .system. property if it's from an older item modifier that was added to an item pre-v10.
In the case I was seeing, the attachment object had data but not system, so this null check doesn't actually do anything.
There was a problem hiding this comment.
Yeah, I noticed that a few times.
|
looks solid to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.