Foundry 10 #1079
Merged
Foundry 10 #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* note: this commit has several incomplete changes which result in broken functionality (I'll add a comment on the issue) StarWarsFoundryVTT#1066
Co-authored-by: Matt Stoolman <Esrin@users.noreply.github.com>
Co-authored-by: Matt Stoolman <Esrin@users.noreply.github.com>
* popout editor now properly retrieves current value * attachments and qualities can be attached to weapons and ships StarWarsFoundryVTT#1066
* fix specialization creation StarWarsFoundryVTT#1066
* fix all importers StarWarsFoundryVTT#1066
* remove data call on adversary sheet StarWarsFoundryVTT#1066
* fix item quality ranks StarWarsFoundryVTT#1066
* fix data call in settings StarWarsFoundryVTT#1066
Closed
Esrin
approved these changes
Sep 9, 2022
| this.item.flags.starwarsffg.loaded = true; | ||
|
|
||
| const specializationTalents = data.system.talents; | ||
| const specializationTalents = data.data.talents; |
There was a problem hiding this comment.
Is this one deliberately going from system to data?
There was a problem hiding this comment.
Yes, it is intentionally going to data.data. It doesn't generate a warning and breaks with system so I think this should be left as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.datacall when adding an attachment to a weapon from a compendium (this will generate a warning).datacalls