Update GHA pants-init action to fix build #5782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github updated the default minor version of python 3.9.x The cache key did not include the minor version which broke things for us. Luckily, this was already fixed in pantsbuild/actions#6. The fix requires an update to the `./pants` entrypoint/bootstrap script which was updated in pantsbuild/setup#128. updated `./pants` with: curl -L -O https://static.pantsbuild.org/setup/pants && chmod +x ./pants
pull-request-size
bot
added
the
size/M
arm4b
approved these changes
Oct 22, 2022
|
The version of python installed for pants (inside this pants-init action) is unrelated to the versions we use for our code. |
|
If we do want to change the version of python used by pants, there is an action input parameter that handles that. |
amanda11
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github updated the default minor version of python 3.9.x The cache key did not include the minor version which broke things for us.
Luckily, this was already fixed in pantsbuild/actions#6. The fix requires an update to the
./pantsentrypoint/bootstrap script which was updated in pantsbuild/setup#128.Based on pants docs, I updated
./pantswith: