Use python imports to identify fixtures (part 6/6)

[cognifloyd]

Background

I'm working towards introducing pants. Eventually I would like to use pants to run tests to take advantage of the fine-grained per-file caching of results that accounts for dependencies by python files (pants infers the deps by reading the python files).

In order to use the fine-grained caching, Pants needs to know which tests rely on which fixtures. We could add extra metadata to tie the tests to the fixtures, but that would be an additional maintenance burden that will become out-of-date. We can also include all fixtures for all tests, but then we don't benefit from the fine-grained per-file caching. However, pants can already infer dependencies based on python imports, so that is what this PR (and several follow-up PRs) takes advantage of.

Overview

This PR does the following:

• turn every fixture into an importable python module with an __init__.py.
• add a fixture.py file in each fixture that uses the fixturesloader utils (where helpful) to identify itself with PATH and NAME vars.
• in every test that uses a given fixture, import PATH and/or NAME vars from that fixture.

This PR focuses on the last couple fixtures.

Statistics

Changes Summary (mostly in st2reactor with a little in the winrm_runner):

• 1 line updated in changelog
• 5 copies of fixture.py (each has 13 lines of copyright/license header): 16*5=+80 lines
  • some of these are actually __init__.py when that made more sense for a directory of fixtures
• -11 +17 lines changed in test files to use the new fixture vars.
  We may find need to address additional fixtures in the future, but this is the end of this series of PRs.

[rush-skills]

LGTM

[rush-skills]

is the . necessary here?

[cognifloyd]

Alternatively we might be able to use this:

Suggested change

	from .fixtures import FIXTURES_PATH
	from tests.unit.fixtures import FIXTURES_PATH

Relative import was simpler. But I'm fine either way.