Enable setting ttl for MockDatastoreService #5468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows people to test their code if they are already setting a ttl.
pull-request-size
bot
added
the
size/S
|
|
amanda11
approved these changes
Dec 7, 2021
|
@amanda11 Thanks for the approval. I fixed the formatting and updated changelog. I'm not yet seeing how this change would have impacted the build, so not sure if that's just an ephemeral issue or something that was expecting ttl to be rejected.. I'm now working on setting up a full local development environment for the st2 codebase itself. |
|
Merged, thanks @ytjohn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows people to test their code if they are already setting a ttl. This resolves #4880
I think we would also be fine with not issuing a log warning, but put that in for completeness.