-
-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action delete API rework - support for action file deletion #5360
Action delete API rework - support for action file deletion #5360
Conversation
@m4dcoder I have added unit tests, updated existing unit test and done other minor changes as suggested. Please review. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment on wording in the schema, but @nzlosh point more important.
…ication to have backward compatibility
st2 action delete <pack>.<action>
will delete database entry onlyst2 action delete --remove-files <pack>.<action>
will delete database entry and files.{"remove_files": true}
in the body then it will remove related action files from disk along with database entry.{"remove_files": false}
or no additional argument in action DELETE method body will remove only database entry.