Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct error message when have error decrypting parameter and also have keys that convert #5328

Merged
merged 12 commits into from
Sep 13, 2021

Conversation

amanda11
Copy link
Contributor

When you have an action that takes two key/value pairs whereby:

  1. One parameter is encrypted and the key/value isnt' set
  2. Another parameter is of a type other than string, and key/value pair is set

When the error is reported for the parameter that can't be decrypted, on handling that error another exception is raised when it attempts to validate the parameter json in regard to the parameter in key/value store that needs to be converted. This means that the incorrect error message is reported.
See #5312 for an example case of when this occurs.

Closes #5312

@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Aug 13, 2021
@pull-request-size pull-request-size bot added size/L PR that changes 100-499 lines. Requires some effort to review. and removed size/M PR that changes 30-99 lines. Good size to review. labels Aug 13, 2021
@amanda11 amanda11 added this to the 3.6.0 milestone Aug 13, 2021
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines. Good size to review. and removed size/L PR that changes 100-499 lines. Requires some effort to review. labels Aug 13, 2021
@CLAassistant
Copy link

CLAassistant commented Sep 6, 2021

CLA assistant check
All committers have signed the CLA.

@pull-request-size pull-request-size bot added size/L PR that changes 100-499 lines. Requires some effort to review. and removed size/M PR that changes 30-99 lines. Good size to review. labels Sep 6, 2021
@amanda11
Copy link
Contributor Author

amanda11 commented Sep 6, 2021

@Kami Thanks for review comments, I've addressed them now - and in process, realised I had one of the UT wrong! Ready for re-review when you get a chance.

Copy link
Contributor

@winem winem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amanda11 amanda11 merged commit 58f54cb into master Sep 13, 2021
@amanda11 amanda11 deleted the decrypt_kv_convert branch September 13, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug size/L PR that changes 100-499 lines. Requires some effort to review.
Projects
None yet
4 participants