Remove Python 2.7 from tests and builds #5090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
4 tasks
blag
force-pushed
the
remove-python2.7
branch
from
dfcd5a0 to
719dd94
Compare
pull-request-size
bot
added
size/L
nmaludy
approved these changes
Dec 1, 2020
blag
force-pushed
the
remove-python2.7
branch
from
4518150 to
1a92711
Compare
blag
force-pushed
the
remove-python2.7
branch
from
1a92711 to
b0f62f6
Compare
blag
commented
Dec 2, 2020
| @@ -450,7 +441,7 @@ compilepy3: | |||
| .st2common-circular-dependencies-check: | |||
| @echo "Checking st2common for circular dependencies" | |||
| find ${ROOT_DIR}/st2common/st2common/ -name \*.py -type f -print0 | xargs -0 cat | grep st2reactor ; test $$? -eq 1 | |||
| find ${ROOT_DIR}/st2common/st2common/ \( -name \*.py ! -name runnersregistrar\.py -name \*.py ! -name compat\.py | -name inquiry\.py \) -type f -print0 | xargs -0 cat | grep st2actions ; test $$? -eq 1 | |||
| find ${ROOT_DIR}/st2common/st2common/ \( -name \*.py ! -name runnersregistrar\.py -name \*.py ! -name compat\.py ! -name inquiry\.py \) -type f -print0 | xargs -0 cat | grep st2actions ; test $$? -eq 1 | |||
There was a problem hiding this comment.
@m4dcoder Is this change acceptable to you? I think this is what you were trying to do with this commit, but I want to double check with you.
Without this fix we get two errors: find: missing ) and Command not found '-name', which I think is caused by the | character terminating the find command prematurely.
I also noticed that -name \*.py is in the find parameters twice, but I don't think that would cause any issues.
arm4b
reviewed
Dec 3, 2020
arm4b
suggested changes
Dec 3, 2020
blag
force-pushed
the
remove-python2.7
branch
from
ab703c7 to
d11bc0e
Compare
blag
force-pushed
the
remove-python2.7
branch
from
d11bc0e to
cf63d93
Compare
arm4b
reviewed
Dec 8, 2020
arm4b
reviewed
Dec 8, 2020
Co-authored-by: Eugen Cusmaunsa <stackstorm@armab.io>
This was referenced Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.travis.ymlandMakefile.travis.ymlto generate the build matrix implicitly (eg:env.jobsandjobs)