-
-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning messages to logs if StackStorm running with python 2 #5043
Conversation
Output from systemctl status on one of the stackstorm services just after starting:
Output from a log file on startup: Warning appeared in following log files:
Placement in the service_setup.py ensures that it goes to the log file as well as to systemctl status. Does not cover the changes for reporting via st2ctl, will need to be covered in separate PR. Not added as would be in a different area of code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Also it's nice to see that implementation for this is actually so easy & clean.
Add warning messages in log files if StackStorm service is using python2
Warning message appears in log file, and also systemctl status (until journal will get wrapped).
Addresses part of #5041 and #4938
Does not cover the reporting from st2ctl