-
-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix master builds #4869
Fix master builds #4869
Conversation
gitpython requires gitdb2, but that has removed some things in newer versions, and 2.11.1 had an open ended dep. So, update gitpython to a newer version that has more specific version requirements for gitdb2. This should fix these errors: gitpython-developers/GitPython#983 https://travis-ci.org/StackStorm/st2/jobs/652088774#L9416 https://circleci.com/gh/StackStorm-Exchange/stackstorm-sumologic/155 Thanks to blag for tracking down the bug.
This won't fix all of the build errors on master. There are other issues as well, this is just the only one with a clear fix so far. |
Other issues include:
Once we figure those issues out, they should probably go in separate PRs. Can we merge this fix even without resolving those other issues? |
@cognifloyd If these issues are causing the errors in the CI above, then you have to fix them before we can merge. |
Nevermind, this PR should work just fine. I also removed the (long deprecated) There are more than one pack CI builds that are failing due to the same issue. |
I just cherry-picked the |
e4d3d69
to
fa81ed5
Compare
fa81ed5
to
2862c70
Compare
requests 2.22.0 had conflicting requirements on idna. The primary requirement said idna>=2.5,<2.9 but the security extra (which we use) required any idna>=2.0.0. idna 2.9 was released 2 days ago requests 2.23.0 was released today
It's GREEN! 💚 |
It's arguable pip requirements fix needs that amount of changes. I'd prefer to not mix different changes in one PR. This keeps history clear and straightforward. Additionally, per previous comment we're missing CHANGELOG record which is required for pip requirements update for st2 core. Even though, many thanks for fixing master! ✔️ |
@blag asked me to get rid of the 777 permissions workaround affecting the entire home directory. Also, I offered to do separate updates for each of the issues and was told that nothing could be merged till it was all green. So, I fixed three issues in this PR to make it green. So, no, this was not just a pip dep update. Changelog PR |
Fixes includes:
Update gitpython requirement (Thanks to @blag for tracking down the bug.)
versions, and 2.11.1 had an open ended dep. So, update gitpython to a
newer version that has more specific version requirements for gitdb2.
ModuleNotFoundError: No module named 'gitdb.utils.compat' gitpython-developers/GitPython#983
https://travis-ci.org/StackStorm/st2/jobs/652088774#L9416
https://circleci.com/gh/StackStorm-Exchange/stackstorm-sumologic/155
Drop --no-site-packages from virtualenv calls
Make travis use the travis user instead of stanley, and add a restricted permissions workaround for the root user.
Update requests which had a conflicting dep on idna (primary said
idna>=2.5,<2.9
but security extra wanted anyidna>=2.0.0
. idna 2.9 was released a couple of days ago, and requests 2.23.0 with fixed deps was released today.