Log non-fatal errors during service bootstrap phase under DEBUG instead of ERROR #4630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
registration) as debug since they are non-fatal. Previously they were logged under error which caused a lot of confusion.
Kami
commented
Apr 10, 2019
| @@ -245,7 +245,7 @@ def create_trigger_db(trigger_api): | |||
| return trigger_db | |||
|
|
|||
|
|
|||
| def create_or_update_trigger_db(trigger): | |||
| def create_or_update_trigger_db(trigger, log_not_unique_error_as_debug=False): | |||
| """ | |||
There was a problem hiding this comment.
Note: We want to default this to False everywhere because in other context, this error would indeed be fatal.
arm4b
approved these changes
Apr 10, 2019
|
|
||
| extra = {'trigger_db': trigger_db} | ||
| LOG.audit('Trigger created for parameter-less internal TriggerType. Trigger.id=%s' % | ||
| (trigger_db.id), extra=extra) | ||
| except StackStormDBObjectConflictError: | ||
| except (NotUniqueError, StackStormDBObjectConflictError): |
|
Overall, I would be much more happy if we could add a consistent test for it, but as mentioned above - this would be hard and there are a lot of edge cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the code to log non-fatal errors under
DEBUGlog level instead ofERROR.Previously we logged those under
ERRORwhich caused a lot of unnecessary confusion.Background, Context
During service bootstrap phase and when running register content script we register internal trigger types (among other things).
This operation is idempotent and as such, some of the possible errors (not unique and object already exists error) are non-fatal. An error represents a non-fatal race which just means that a particular trigger has already been registered by a different service / process.
NOTE: Adding tests for that would be hard. We would need to replicate the race which means spawning multiple processes (using multiple eventlets won't work here, we need real parallelism to replicate it) and ensure tests run on multi core / CPU server...
Resolves #3933.
Output
Before:
After (as you can see, the error is only logged under debug when
--verboseflag is used):TODO