Fix regression with generic action notify trigger in notifier service #4591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to only be dispatched on completed states, but not on custom states if action_sensor.emit_when config option was configured. Issue was inadverently introduced in #4536, Issue reported by Hiroyasu OHYAMA (@userlocalhost).
This was referenced Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change in #4536 inadvertently introduced a regression inside notifier service which would cause generic action notify trigger to only be dispatched for completed states even if custom states were specified using
action_sensor.emit_whenconfig option.Tests didn't catch this issue, because we only had tests for
_post_generic_triggermethod, but not for mainprocess()one where the issue lived.Thanks to Shu Sugimoto (@shusugmt) for reporting this issue.