Improve st2.conf migration for the new services #4415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Much wow, I didn't expect this to pass the unit tests. |
|
Nice work and a good change 👍 We just need to confirm services run "out of the box" on a dev setup (I will try / verify that). Do we need a changelog entry for this? |
|
I'll include Changelog as well as enable default |
added 12 commits
October 29, 2018 17:01
Kami
approved these changes
Oct 30, 2018
|
Tested it locally, seems to work fine (aka it doesn't negatively affects devenv) 👍 |
|
Thanks for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial problem is that adding new st2 service requires us to include upgrade instructions like https://docs.stackstorm.com/upgrade_notes.html#st2-v2-9 and force users to handle
st2.confdiffs.The way to improve this story is to make default
st2.conflogging settings work in prod deployments and so transition, migration or absense of specific directives in st2.conf doesn't fail startup.This is an issue in infra (/~https://github.com/StackStorm/ops-infra/pull/295), configuration management requiring version-to-version migrations and overall bad. Having st2 core handling it right would be a better path.
Ideally ST2 core should have safe defaults that even no
st2.confconfig would allow us to start the services with no issues.As mentioned in /~https://github.com/StackStorm/st2/pull/4382/files#r224189566, try to use
/etc/st2/path as default setting for the new st2 services logging config and see what happens and what other changes may be needed.Services