feat: Secret resource #3110

sfc-gh-fbudzynski · 2024-10-02T13:56:50Z

Changes

add snowflake_secret_with_client_credentials resource
add snowflake_secret_with_authorization_code_grant resource
add snowflake_secret_with_basic_authentication resource
add snowflake_secret_with_generic_string resource
fix parsing oauth_scopes list with ParseCommaSeparatedStringArray()

Test Plan

acceptance tests

References

https://docs.snowflake.com/en/sql-reference/sql/create-secret

TODO

datasource
tests for externally changed secret type

…aming clash

…validationType

github-actions · 2024-10-10T12:10:41Z

Integration tests failure for 9dea35cc44894aa14b7aee86e70ff75f166591b3

pkg/resources/secret_with_basic_authentication.go

pkg/resources/secret_with_oauth_authorization_code_grant.go

pkg/resources/secret_with_oauth_client_credentials_acceptance_test.go

pkg/resources/secret_with_basic_authentication_acceptance_test.go

pkg/resources/secret_common.go

pkg/resources/secret_with_basic_authentication.go

pkg/resources/secret_with_oauth_authorization_code_grant.go

pkg/resources/secret_with_oauth_client_credentials_acceptance_test.go

pkg/resources/secret_with_oauth_authorization_code_grant_acceptance_test.go

sfc-gh-asawicki · 2024-10-13T19:38:00Z

pkg/resources/secret_with_oauth_authorization_code_grant_acceptance_test.go

 					))
 				},
-				Config: config.FromModel(t, secretModel),
+				Config: config.FromModel(t, secretModelExternalChanges),


I am not quite sure about this test, why we alter both the config and externally?

because i didnt correct this one after changes to handling token_expiry_time field
I will correct that and use properly, it should test the external change

pkg/resources/secret_with_oauth_authorization_code_grant_acceptance_test.go

pkg/resources/secret_with_oauth_client_credentials_acceptance_test.go

docs/resources/secret_with_authorization_code_grant.md

pkg/resources/secret_common.go

pkg/resources/secret_with_basic_authentication.go

pkg/resources/secret_common.go

pkg/resources/secret_with_basic_authentication.go

pkg/resources/secret_with_basic_authentication_acceptance_test.go

pkg/resources/secret_with_oauth_authorization_code_grant.go

…oint from 0.97 -> 0.98

github-actions · 2024-10-14T11:58:51Z

Integration tests failure for 1a9a6db5d90a1aae584ad610aa61662257321624

sfc-gh-jmichalak · 2024-10-15T08:42:22Z

pkg/sdk/secrets_def.go


 //go:generate go run ./poc/main.go
+const (


Nit: we usually have separated types for such groups of enum values.

It will be added with the PR for externally changed secret_types

github-actions · 2024-10-15T12:13:45Z

Integration tests failure for b202fdde49d84844251674844f50696e17315af8

sfc-gh-asawicki

Please update on main to have a longer timeout for acceptance tests

pkg/resources/secret_with_basic_authentication.go

sfc-gh-asawicki · 2024-10-15T20:59:25Z

pkg/resources/secret_with_basic_authentication_acceptance_test.go

@@ -67,8 +67,9 @@ func TestAcc_SecretWithBasicAuthentication_BasicFlow(t *testing.T) {
 					resource.TestCheckResourceAttr(secretName, "describe_output.0.name", name),
 					resource.TestCheckResourceAttr(secretName, "describe_output.0.database_name", id.DatabaseName()),
 					resource.TestCheckResourceAttr(secretName, "describe_output.0.schema_name", id.SchemaName()),
-					resource.TestCheckResourceAttr(secretName, "describe_output.0.secret_type", "PASSWORD"),
+					resource.TestCheckResourceAttr(secretName, "describe_output.0.secret_type", sdk.SecretTypePassword),


with the separate type change you will have to do sdk.SecretTypePassword -> string(sdk.SecretTypePassword) in multiple tests

It will be changed in a PR with the secret type change

okay, I will keep this open then

sfc-gh-asawicki · 2024-10-15T21:01:46Z

pkg/resources/show_and_describe_handlers.go

@@ -43,6 +43,28 @@ type showMapping struct {
 	normalizeFunc  func(any) any
 }

+// handleExternalValueChangesToObjectInDescribe assumes that describe output is kept in DescribeOutputAttributeName attribute
+func handleExternalValueChangesToObjectInDescribe(d *schema.ResourceData, mappings ...describeMapping) error {


this is copy-paste of handleExternalChangesToObjectInShow, only the var names and attribute name changes. Please extract this as a common body (it may be done in a separate PR)

github-actions · 2024-10-16T14:25:44Z

Integration tests failure for b202fdde49d84844251674844f50696e17315af8

## Changes * Added secret_type computed filed to secret resources * Added CustomDiff for handling external change of secret_type * Refactored show_and_describe_handlers for flat describe_output and show_output * Tested external change of secret type for each resource ## Test Plan  * [x] acceptance tests ## References  * #3110 (comment) * #3110 (comment)

## [0.98.0](v0.97.0...v0.98.0) (2024-11-08) Feature scope readiness for V1: [link](/~https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/v1-preparations/ESSENTIAL_GA_OBJECTS.MD) ([Roadmap reference](/~https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#wrap-up-the-functional-scope)). :exclamation: Migration guide: [v0.97.0 -> v0.98.0](/~https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v0970--v0980) ### 🎉 What's new - New resources: - authentication_policy ([#3098](#3098)), references [#2880](#2880) - external_volume ([#3106](#3106)), partially references [#2980](#2980) - stream_on_directory_table ([#3129](#3129)) - stream_on_view ([#3150](#3150)) - primary_connection, secondary_connection ([#3162](#3162)) - secret_with_basic_authentication, secret_with_generic_string, secret_with_oauth_authorization_code_grant, secret_with_oauth_client_credentials ([#3110](#3110)), ([#3141](#3141)) - New data sources: - connections ([#3155](#3155)), ([#3173](#3173)) - secrets ([#3131](#3131)) - Reworked: - provider configuration hierarchy ([#3166](#3166)), references [#1881](#1881), [#2145](#2145), [#2925](#2925), [#2983](#2983), [#3104](#3104) - provider configuration fields ([#3152](#3152)) streams data source ([#3151](#3151)) - SDK upgrades: - Upgrade tag SDK ([#3126](#3126)) - Recreate streams when they are stale ([#3129](#3129)) ### 🔧 Misc - Add object renaming research summary ([#3172](#3172)) - Test support for object renaming ([#3130](#3130)), ([#3147](#3147)), ([#3154](#3154)) - Add tests to issue [#3117](#3117) ([#3133](#3133)) - New roadmap entry ([#3158](#3158)) - Test more authentication methods ([#3178](#3178)) - Minor fixes ([#3174](#3174)) ### 🐛 Bug fixes - Apply various fixes ([#3176](#3176)), this addresses BCR 2024_08, references [#2717](#2717), [#3005](#3005), [#3125](#3125), [#3127](#3127), [#3153](#3153) - Connection and secret data sources tests ([#3177](#3177)) - Fix grant import docs ([#3183](#3183)), resolves [#3179](/~https://github.com/Snowflake-Labs/terraform-provider-snowflake/discussions/3179) - Fix user resource import ([#3181](#3181)) - Handle external type changes in stream resources ([#3164](#3164)) - Do not use OR REPLACE on initial creation in resources with copy_grants ([#3129](#3129)) - Address issue [#2201](#2201) by introducing new stream resources Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>

sfc-gh-fbudzynski added 30 commits September 24, 2024 10:14

initial secret_def file for sdk

58d5794

naming changes to secret create options

f1488ca

create secrets and alter with two basic tests

752f924

unit tests for alter

d7ae12f

add tests for all four create types

57ca19a

rename previous secret to secretReference in common_types.go due to n…

8d55a63

…aming clash

secrets gen with drop, show and desc

9894799

all unit tests

e4a0827

init for integration tests

3bb8c85

added secret to client.go and created secret_client

4130618

added like and in to showByID for secret

fc85c66

init for integration tests

aa64511

secret_def changes

ab8bee1

tests for two methods of creating secret

3541c70

changed refresh token expiry time from string to time.Time

180a7ce

added remaining integration tests

7a9ad92

linter

0e9cf94

linting

deadc65

removing comment

235fbe5

mid review commit before generating assertions

73eeb63

rebase conflict resolved

bd0b64f

tests pass after changing to []string for oauthScopes

2050b85

readded unit tests

59c7b14

added CreateApiAuthenticationWithRequest to security integration client

df7a8ff

changes to secret after review, all tests pass

eed310a

added assert for details

af2e030

linter hints applied

4ccc4e7

updated generator README with validation issue for ConflictingFields …

34983af

…validationType

updated after re-review

bdf2585

test changed to use errMoreThanOneOf

7791f33

sfc-gh-fbudzynski added 3 commits October 10, 2024 11:46

resolved to Arturs comments

e304793

linter suggestions

c1115fa

Merge branch 'main' into secret-resource

9dea35c

sfc-gh-asawicki requested review from sfc-gh-asawicki, sfc-gh-jcieslak and sfc-gh-jmichalak October 10, 2024 11:39

sfc-gh-jmichalak requested changes Oct 10, 2024

View reviewed changes

refactor after Kuba re-review comments

bdb7fff

sfc-gh-asawicki requested changes Oct 13, 2024

View reviewed changes

sfc-gh-fbudzynski added 2 commits October 14, 2024 09:29

changes not to abuse pointer on models

dba8478

linter adjustments

40ecd49

sfc-gh-jcieslak reviewed Oct 14, 2024

View reviewed changes

changed username to sensitive, adjusted docs and migration guide to p…

1a9a6db

…oint from 0.97 -> 0.98

sfc-gh-jcieslak approved these changes Oct 14, 2024

View reviewed changes

sfc-gh-jmichalak approved these changes Oct 15, 2024

View reviewed changes

Merge branch 'main' into secret-resource

b202fdd

sfc-gh-asawicki self-requested a review October 15, 2024 20:51

sfc-gh-asawicki requested changes Oct 15, 2024

View reviewed changes

sfc-gh-asawicki self-requested a review October 16, 2024 12:04

sfc-gh-asawicki approved these changes Oct 16, 2024

View reviewed changes

sfc-gh-fbudzynski merged commit 16a812d into main Oct 17, 2024
8 of 9 checks passed

sfc-gh-fbudzynski deleted the secret-resource branch October 17, 2024 07:23

snowflake-release-please bot mentioned this pull request Oct 17, 2024

chore(main): release 0.98.0 #3137

Merged

sfc-gh-fbudzynski mentioned this pull request Oct 17, 2024

fix: handle external change of secret type #3141

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Secret resource #3110

feat: Secret resource #3110

sfc-gh-fbudzynski commented Oct 2, 2024 •

edited

Loading

github-actions bot commented Oct 10, 2024

sfc-gh-asawicki Oct 13, 2024

sfc-gh-fbudzynski Oct 14, 2024

github-actions bot commented Oct 14, 2024

sfc-gh-jmichalak Oct 15, 2024

sfc-gh-fbudzynski Oct 15, 2024

github-actions bot commented Oct 15, 2024

sfc-gh-asawicki left a comment

sfc-gh-asawicki Oct 15, 2024

sfc-gh-fbudzynski Oct 16, 2024 •

edited

Loading

sfc-gh-asawicki Oct 16, 2024

sfc-gh-asawicki Oct 15, 2024

github-actions bot commented Oct 16, 2024

feat: Secret resource #3110

feat: Secret resource #3110

Conversation

sfc-gh-fbudzynski commented Oct 2, 2024 • edited Loading

Changes

Test Plan

References

TODO

github-actions bot commented Oct 10, 2024

sfc-gh-asawicki Oct 13, 2024

Choose a reason for hiding this comment

sfc-gh-fbudzynski Oct 14, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 14, 2024

sfc-gh-jmichalak Oct 15, 2024

Choose a reason for hiding this comment

sfc-gh-fbudzynski Oct 15, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 15, 2024

sfc-gh-asawicki left a comment

Choose a reason for hiding this comment

sfc-gh-asawicki Oct 15, 2024

Choose a reason for hiding this comment

sfc-gh-fbudzynski Oct 16, 2024 • edited Loading

Choose a reason for hiding this comment

sfc-gh-asawicki Oct 16, 2024

Choose a reason for hiding this comment

sfc-gh-asawicki Oct 15, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 16, 2024

sfc-gh-fbudzynski commented Oct 2, 2024 •

edited

Loading

sfc-gh-fbudzynski Oct 16, 2024 •

edited

Loading