Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch services to awsd default env #89

Merged
merged 6 commits into from
Jun 11, 2024
Merged

Switch services to awsd default env #89

merged 6 commits into from
Jun 11, 2024

Conversation

adelinag08
Copy link
Contributor

@adelinag08 adelinag08 commented Jun 10, 2024 •
edited
Loading

Scope

Implemented:

  • Switch base environment to awsd
  • Add new flag --custom-auth-url if legacy boxer needs to be used for authentication

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Self-review done.

@adelinag08 adelinag08 changed the title Switch boxer to aws uris Switch services to awsd default env Jun 10, 2024
@adelinag08 adelinag08 marked this pull request as ready for review June 10, 2024 15:07
@adelinag08 adelinag08 requested a review from a team as a code owner June 10, 2024 15:07
george-zubrienko
george-zubrienko approved these changes Jun 10, 2024
View reviewed changes
Copy link

@george-zubrienko george-zubrienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@adelinag08 adelinag08 merged commit bfb1456 into main Jun 11, 2024
1 check passed
@adelinag08 adelinag08 deleted the switch-to-aws branch June 11, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@george-zubrienko george-zubrienko george-zubrienko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adelinag08 @george-zubrienko