Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add environment to cached token #80

Merged
merged 3 commits into from
May 24, 2024
Merged

Add environment to cached token #80

merged 3 commits into from
May 24, 2024

Conversation

adelinag08
Copy link
Contributor

@adelinag08 adelinag08 commented May 24, 2024 •
edited
Loading

Closes #60

Scope

Implemented:

  • Save environment together with the cached token

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Self-review done.

@adelinag08 adelinag08 marked this pull request as ready for review May 24, 2024 11:34
@adelinag08 adelinag08 requested a review from a team as a code owner May 24, 2024 11:34
s-vitaliy
s-vitaliy approved these changes May 24, 2024
View reviewed changes
Copy link

@s-vitaliy s-vitaliy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adelinag08 adelinag08 merged commit 5e56ac1 into main May 24, 2024
1 check passed
@adelinag08 adelinag08 deleted the fix-cached-token branch May 24, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-vitaliy s-vitaliy s-vitaliy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Environment setting is affected by cache
2 participants
@adelinag08 @s-vitaliy