Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snake case payloads #77

Merged
merged 12 commits into from
May 24, 2024
Merged

Snake case payloads #77

merged 12 commits into from
May 24, 2024

Conversation

adelinag08
Copy link
Contributor

@adelinag08 adelinag08 commented May 15, 2024 •
edited
Loading

Closes #57

Scope

Implemented:

  • User now provides snake case payloads
  • Mark initiator and reason flags as required for cancel crystal jobs command
  • Remove not used authcheck.go

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Self-review done.

@adelinag08 adelinag08 marked this pull request as ready for review May 23, 2024 09:33
@adelinag08 adelinag08 requested a review from a team as a code owner May 23, 2024 09:33
s-vitaliy
s-vitaliy approved these changes May 23, 2024
View reviewed changes
@adelinag08 adelinag08 merged commit bebc038 into main May 24, 2024
1 check passed
@adelinag08 adelinag08 deleted the snake_case_payloads branch May 24, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-vitaliy s-vitaliy s-vitaliy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Convert all payloads to snake case
2 participants
@adelinag08 @s-vitaliy