Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add claim string & crystal payload validation #112

Merged
merged 13 commits into from
Jan 28, 2025
Merged

Add claim string & crystal payload validation #112

merged 13 commits into from
Jan 28, 2025

Conversation

adelinag08
Copy link
Contributor

@adelinag08 adelinag08 commented Jan 16, 2025 •
edited
Loading

Closes #91
Closes #72
Closes #87
Closes #79

Scope

Implemented:

  • Add validation for add and remove actions for claims
  • Validate that algorithm_parameters exists for crystal payloads before sending request
  • Retrieve the initiator for ML run cancellations from the token's boxer.sneaksanddata.com/user claim
  • Additional unit tests
  • Add some missing docs

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Self-review done.

@adelinag08 adelinag08 requested a review from a team as a code owner January 16, 2025 09:38
@github-actions GitHub Actions
Copy link

New coverage report available ✨

@github-actions GitHub Actions
Copy link

New coverage report available ✨

@adelinag08 adelinag08 changed the title Fix incorrect claim Add claim string validation Jan 16, 2025
@github-actions GitHub Actions
Copy link

New coverage report available ✨

@github-actions GitHub Actions
Copy link

New coverage report available ✨

@github-actions GitHub Actions
Copy link

New coverage report available ✨

@github-actions GitHub Actions
Copy link

New coverage report available ✨

@adelinag08 adelinag08 changed the title Add claim string validation Add claim string & crystal payload validation Jan 17, 2025
@github-actions GitHub Actions
Copy link

New coverage report available ✨

@github-actions GitHub Actions
Copy link

New coverage report available ✨

@github-actions GitHub Actions
Copy link

New coverage report available ✨

@github-actions GitHub Actions
Copy link

New coverage report available ✨

george-zubrienko
george-zubrienko approved these changes Jan 28, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

New coverage report available ✨

@adelinag08 adelinag08 merged commit d6198df into main Jan 28, 2025
1 check passed
@adelinag08 adelinag08 deleted the fix-incorrect-claim branch January 28, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@george-zubrienko george-zubrienko george-zubrienko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@adelinag08 @george-zubrienko