feat: add lambda module for subscription filtering #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![github-advanced-security[bot]](/~https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
terraform/scheduling/main.tf
Outdated
Comment on lines
106
to
116
| module "custom_lambda" { | ||
| source = "../modules/lambda" | ||
| log_group_name = "/aws/ecs/minecraft-firelens-logs" | ||
| log_group_arn = "arn:aws:logs:ap-northeast-1:528163014577:log-group:/aws/ecs/minecraft-firelens-logs:*" | ||
| filter_patterns = ["{ ($.log = \"*joined*\") || ($.log = \"*Disconnected*\") || ($.log = \"*left*\") }", "{ ($.log = \"<*\") }"] | ||
| sns_topic_arn = data.aws_sns_topic.my_sns.arn | ||
| slack_webhook_url = "https://hooks.slack.com/services/${var.WEBHOOK_PATH}" | ||
|
|
||
| owners = local.owners | ||
| environment = local.environment | ||
| } |
Check failure
Code scanning / defsec
IAM policy should avoid use of wildcards and instead apply the principle of least privilege
|
|
|
|
|
|
|
|
|
|
|
|
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
|
|
|
|
|
CLI Command Output: |
|
CLI Command Output: |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
|
|
|
CLI Command Output: |
|
CLI Command Output: |
ShotaroMatsuya
force-pushed
the
feat/add_lambda_module
branch
from
f224a31 to
c2cd370
Compare
|
|
Snyk Container Vulnerabilities
|
Snyk Container Vulnerabilities
|
|
|
Snyk Scan
|
Snyk Scan
|
|
fixes #68 |
|
|
Snyk Scan
|
Snyk Scan
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #21
fixes #68