Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: clean up the project configuration for RN0.71, aligning some packages to the right version #271

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

kelset
Copy link
Contributor

@kelset kelset commented Aug 16, 2023

Description

While checking out the fixtures test app in this repo I noticed that some things were not quite as they should, so I cleaned it up (with the help of @tido64) and now the repo is more properly aligned to the RN 0.71 requirements.

(ignore the branch name 🤐)

Reviewers’ hat-rack 🎩

  • run the fixtures app and everything should work as expected

Screenshots or videos (if needed)

All just working as expected:

Screenshot 2023-08-16 at 14 10 55

Checklist

kelset and others added 3 commits August 16, 2023 12:41
bump RNTA to latest

clean up root config too

now everything works

a bit more cleanup

rnta should only be in the example folder
@kelset
Copy link
Contributor Author

kelset commented Aug 16, 2023

I have signed the CLA!

1 similar comment
@tido64
Copy link
Contributor

tido64 commented Aug 16, 2023

I have signed the CLA!

Copy link
Contributor

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, thanks a lot for doing a cleanup ❤️ OSS ❤️

@fortmarek fortmarek merged commit 21ec133 into Shopify:master Aug 18, 2023
@kelset kelset deleted the kelset/update-to-72 branch August 21, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants