Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using 'auto' as value of spacing props #118

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

sbalay
Copy link
Contributor

@sbalay sbalay commented Dec 1, 2021

Summary

When defining spacing props of the theme, only numeric values are allowed. However, in some cases it also useful to use auto as a spacing value, specially for margins.

This PR changes the typings of spacing props to allow usage of the string auto as a value as well.

@sbalay sbalay requested review from drmas, jeanp and davebcn87 December 1, 2021 11:43
src/types.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@drmas drmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🚀

@sbalay sbalay merged commit 81012eb into master Dec 1, 2021
@shopify-shipit shopify-shipit bot temporarily deployed to production December 1, 2021 13:30 Inactive
@gvarandas gvarandas deleted the feature/add-auto-value-to-spacing-props branch March 19, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants