stricter gemspec file include #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Reduce gemfile size by not including unnecessary files during packaging
Size reduction: -19.5%
du -k packwerk-3.2.0* 1764 packwerk-3.2.0-new.gem 2164 packwerk-3.2.0.gemWhat approach did you choose and why?
Followed common pattern to explicitly define files and directories to include in the gem. The pattern is described in the The Packaging Style Guide from Rubocop.
What should reviewers focus on?
Any missing required file in the gem.
Type of Change
Checklist