Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme info rework #5197

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Theme info rework #5197

merged 4 commits into from
Jan 15, 2025

Conversation

amcaplan
Copy link
Contributor

WHY are these changes introduced?

Applying the changes in #5170 to themes as well.

WHAT is this pull request doing?

  1. Uses standardized UI Kit components
  2. Removes the version warning - since we warn daily and issue notifications, it doesn't add value here.

Before:

Screenshot 2025-01-15 at 13 18 37

After:

Screenshot 2025-01-15 at 13 23 22

How to test your changes?

shopify theme info

By the way, I noticed that this command doesn't take a --path variable, is that just an oversight? I definitely added one for local testing.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@amcaplan amcaplan requested review from a team as code owners January 15, 2025 11:26
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.11% 8878/11820
🟡 Branches 70.26% 4337/6173
🟡 Functions 75.04% 2324/3097
🟡 Lines
75.67% (+0.01% 🔼)
8394/11093
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
93.83% (-1.23% 🔻)
86.49% (-2.7% 🔻)
90.48% 98.61%

Test suite run success

2005 tests passing in 905 suites.

Report generated by 🧪jest coverage report action from 1b8ad07

Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @amcaplan! Very nice enhancement and clean-up ✨ :)

@amcaplan amcaplan added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 1a922a6 Jan 15, 2025
27 checks passed
@amcaplan amcaplan deleted the theme-info-rework branch January 15, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants