Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make typings compatible with @types/react@18 #4356

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

Lurk
Copy link
Contributor

@Lurk Lurk commented Apr 18, 2022

fixes #4352

what changed

react typing package is updated to the latest version (18.0.5) (also added to package.resolutions because of react-helm)
Most of the work in typings was React.StatelessComponent to React.FC replacement

@welcome
Copy link

welcome bot commented Apr 18, 2022

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #4356 (34087fc) into master (24e47ca) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4356   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         180      180           
  Lines        3248     3248           
=======================================
  Hits         3240     3240           
  Misses          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dd0596...34087fc. Read the comment docs.

Lurk pushed a commit to Lurk/barhamon that referenced this pull request Apr 18, 2022
- add an assertion to "test/typings"
@layershifter layershifter changed the title fixes #4352 (typecheck failed) fix: make typings compatible with @types/react Apr 19, 2022
@layershifter layershifter changed the title fix: make typings compatible with @types/react fix: make typings compatible with @types/react@18 Apr 19, 2022
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lurk great job, and good for us that we declare children explicitly.

@welcome
Copy link

welcome bot commented Apr 19, 2022

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@Lurk
Copy link
Contributor Author

Lurk commented Apr 19, 2022

@layershifter Yeah, if there were no explicit children already, the pull request would be much bigger 🙃

@ExeAy
Copy link

ExeAy commented May 10, 2022

Is this planned to be released any time soon?

@layershifter
Copy link
Member

Released in semantic-ui-react@2.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type check with @types/react 18 failing
4 participants