-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make typings compatible with @types/react@18 #4356
Conversation
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## master #4356 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 180 180
Lines 3248 3248
=======================================
Hits 3240 3240
Misses 8 8 Continue to review full report at Codecov.
|
- add an assertion to "test/typings"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lurk great job, and good for us that we declare children
explicitly.
@layershifter Yeah, if there were no explicit children already, the pull request would be much bigger 🙃 |
Is this planned to be released any time soon? |
Released in |
fixes #4352
what changed
react typing package is updated to the latest version (18.0.5) (also added to package.resolutions because of react-helm)
Most of the work in typings was React.StatelessComponent to React.FC replacement