Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): update event types #4181

Merged
merged 2 commits into from
Aug 2, 2021
Merged

fix(Dropdown): update event types #4181

merged 2 commits into from
Aug 2, 2021

Conversation

aboyce
Copy link
Contributor

@aboyce aboyce commented Mar 23, 2021

Fixes #4165, also includes onAddItem event type.

@welcome
Copy link

welcome bot commented Mar 23, 2021

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@welcome
Copy link

welcome bot commented Aug 2, 2021

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown: Event Typings are Incorrect
2 participants