fix(Transition): schedule changes only on status change
#4060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Sep 8, 2020
| } | ||
|
|
||
| updateStatus = (prevState) => { | ||
| if (this.state.status !== this.state.nextStatus && this.state.nextStatus) { |
There was a problem hiding this comment.
The previous check does not have sense as we should trigger a timer on status change
size-limit report
|
Codecov Report
@@ Coverage Diff @@
## master #4060 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 183 183
Lines 3280 3280
=======================================
Hits 3275 3275
Misses 5 5
Continue to review full report at Codecov.
|
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4059.
See the linked issue for more details. The check that we previously had was false positive on each component's render that may cause unexpected race conditions. It also wrongly cleared a
setTimeout()timer which caused desynchronization issues between CSS and JS.