Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Popup|Visibility): update types definitions for props #4019

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

daigof
Copy link
Contributor

@daigof daigof commented Aug 3, 2020

Fixes #4016.

@welcome
Copy link

welcome bot commented Aug 3, 2020

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@layershifter layershifter changed the title fix: change typescript types definitions for props of popup and visibility fix(Popup|Visibility): update types definitions for props Aug 4, 2020
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated PR's description to auto close the issue, https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue

Thanks 👍

@layershifter layershifter merged commit fc2fd4c into Semantic-Org:master Aug 4, 2020
@welcome
Copy link

welcome bot commented Aug 4, 2020

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup: invalid typings for on property
2 participants