Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Modal): improve examples, use React hooks #4012

Merged
merged 2 commits into from
Jul 31, 2020

Conversation

layershifter
Copy link
Member

This PR:

  • improves examples for Modal component
  • refactors them use React hooks instead of class components
  • adds bundle size fixture

@github-actions
Copy link

size-limit report

Path Size
bundle-size/dist/Button.size.js 70.84 KB (0%)
bundle-size/dist/Icon.size.js 33.41 KB (0%)
bundle-size/dist/Image.size.js 66.13 KB (0%)
bundle-size/dist/Modal.size.js 108.63 KB (0%)
bundle-size/dist/Portal.size.js 49.9 KB (0%)

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2020

Codecov Report

Merging #4012 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4012   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         185      185           
  Lines        3251     3251           
=======================================
  Hits         3246     3246           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 532e3d6...6aaa1d2. Read the comment docs.

case 'OPEN_MODAL':
return {
log: [
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will add the newest logs in the beginning of the array, is it intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, as it creates an order for entries output:

image

@vercel vercel bot requested a deployment to Preview July 31, 2020 11:21 Abandoned
@layershifter layershifter merged commit 5230cd3 into master Jul 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the docs/modal-examples branch July 31, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants