fix(Sidebar): handle clicks properly #3772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3772 +/- ##
=======================================
Coverage 99.83% 99.83%
=======================================
Files 172 172
Lines 3101 3101
=======================================
Hits 3096 3096
Misses 5 5
Continue to review full report at Codecov.
|
layershifter
commented
Sep 2, 2019
layershifter
force-pushed
the
fix/sidebar-click
branch
from
0684b06 to
6ccfaa0
Compare
…/Semantic-Org/Semantic-UI-React into fix/sidebar-click # Conflicts: # package.json # src/modules/Sidebar/Sidebar.js # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3762.
💥 Issue
The source of fixed issue is well described there: #3716 (comment). In short: existing
EventStackabstraction handles events incorrectly sometimes.This PR removes the usage of
EventStackin favor of plainEventListnenerfrom Stardust.