feat(Dropdown): allow selecting an item when pressing the spacebar

[nelsonleite]

Due to accessibility matters (and similarity to the native ), this adds the possibility to select an item via Spacebar and not only with Enter

[welcome]

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

• Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
• Run yarn test locally to catch errors. This ensures all components still behave as they should.
• Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
• Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[codecov-io]

Codecov Report

Merging #3702 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3702      +/-   ##
==========================================
- Coverage   99.83%   99.83%   -0.01%     
==========================================
  Files         175      175              
  Lines        3124     3121       -3     
==========================================
- Hits         3119     3116       -3     
  Misses          5        5

Impacted Files	Coverage Δ
src/modules/Dropdown/Dropdown.js	100% <100%> (ø)	⬆️
src/modules/Popup/Popup.js	98.68% <0%> (-0.04%)	⬇️
src/modules/Checkbox/Checkbox.js	100% <0%> (ø)	⬆️
src/modules/Transition/Transition.js	100% <0%> (ø)	⬆️
src/views/Feed/FeedContent.js	100% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f595fc2...a4a7563. Read the comment docs.

[layershifter]

native <select />

https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_select
Value is not selectable by Spacebar.

listbox, combobox, menubutton

https://www.w3.org/TR/wai-aria-practices/examples/listbox/listbox-collapsible.html
https://www.w3.org/TR/wai-aria-practices-1.1/examples/combobox/aria1.1pattern/listbox-combo.html
https://www.w3.org/TR/wai-aria-practices-1.1/examples/menu-button/menu-button-links.html

No Spacebar, too.

Due to accessibility matters (and similarity to the native )

Can you please clarify to which accessibility pattern you're referring?

[nelsonleite]

The native select selects the value with the spacebar at least in Chrome and Safari. There is no specific a11y pattern that specifies this spacebar usage, but I was trying to mimic the behaviour in some browsers 🙂

[layershifter]

@nelsonleite I have discussed this change also with Stardust UI team as there is also Dropdown component. I will follow up the discussion again, but I think that your PR will be included to next SUIR release 👍 🎉 🚀

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉